adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms
Apache License 2.0
26 stars 58 forks source link

Core WCM RTE inline plugin toolbars not displayed #1374

Closed shravanthprasad closed 2 months ago

shravanthprasad commented 2 months ago

We see an issue with RTE inline toolbars not displayed for core wcm rich text component. Analysis: The JS below with af-apps pkg is causing this issue- /apps/core/fd/components/form/container/v2/container/clientlibs/editorhook/js/toolbaractionhook.js

if(!(hasRichTextLabel || hasRichTextAttribute)){
                editable.config.editConfig.inplaceEditingConfig.editorType="plaintext";
            }

AEM version 6.5.20 core components version 2.24.2 core forms components version 1.1.39-enumB004

shravanthprasad commented 2 months ago

Example page after installing examples pkg - Toolbar not visible

image

After deleting the toolbaractionhook.js and invalidating cache - Toolbar is visible

image
rismehta commented 2 months ago

Duplicate of, https://github.com/adobe/aem-core-forms-components/issues/1371. Closing this

shravanthprasad commented 2 months ago

@rismehta - Thanks for the quick fix. Can you please provide a release(1.1.39-enumB004) with the below fixes on top of the as we have just upgraded our aem version (https://github.com/adobe/aem-core-forms-components/releases/tag/core-forms-components-reactor-1.1.39-enumB004) Fixes: 1)https://github.com/adobe/aem-core-forms-components/pull/1326 - conflicting vault filter 2)https://github.com/adobe/aem-core-forms-components/pull/1376 - rte fix for wcm

rismehta commented 2 months ago

Can you please provide a release(1.1.39-enumB004) with the below fixes on top of the as we have just upgraded our aem version (https://github.com/adobe/aem-core-forms-components/releases/tag/core-forms-components-reactor-1.1.39-enumB004) Fixes: 1)#1326 - conflicting vault filter 2)#1376 - rte fix for wcm

Could you please submit a customer request for this through the support channel ?

shravanthprasad commented 2 months ago

Can you please provide a release(1.1.39-enumB004) with the below fixes on top of the as we have just upgraded our aem version (https://github.com/adobe/aem-core-forms-components/releases/tag/core-forms-components-reactor-1.1.39-enumB004) Fixes: 1)#1326 - conflicting vault filter 2)#1376 - rte fix for wcm

Could you please submit a customer request for this through the support channel ?

Hi @rismehta - Support ticket - E-001352137 Thanks

shravanthprasad commented 2 months ago

@rismehta - Update to this request, the following issues are also reported on our Prod and need it to be added to the release -

https://github.com/adobe/aem-core-forms-components/pull/1326 https://github.com/adobe/aem-core-forms-components/pull/1225 https://github.com/adobe/aem-core-forms-components/pull/1321 https://github.com/adobe/aem-core-forms-components/pull/1376

rismehta commented 2 months ago

@shravanthprasad We are currently backporting the latest changes from the master branch to the release/650 branch through this PR, https://github.com/adobe/aem-core-forms-components/pull/1391. After merging, we will proceed with creating a hotfix. Please note that this process may take some time.

barshat7 commented 2 months ago

We have released the hotfix https://github.com/adobe/aem-core-forms-components/releases/tag/core-forms-components-reactor-1.1.39-enumB010

shravanthprasad commented 2 months ago

@barshat7 - I verified all the fixes and they are working fine with this release. Thank you!