adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms
Apache License 2.0
26 stars 58 forks source link

Revert "FORMS-11259: Avoid dataRef parameter in Iframe when no value… #1379

Closed rismehta closed 2 months ago

rismehta commented 2 months ago

… available (#991)"

This reverts commit b1444983b71891e0ecf4a66a2f7741b88e8332fb.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.24%. Comparing base (ceb51a2) to head (8a35119). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1379 +/- ## ========================================= Coverage 82.24% 82.24% Complexity 902 902 ========================================= Files 103 103 Lines 2337 2337 Branches 317 317 ========================================= Hits 1922 1922 Misses 254 254 Partials 161 161 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 2 months ago

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 2 months ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 95 96 96 75
adobe-bot commented 2 months ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 2 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 2 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 2 months ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious