FORMS-16446 Add isWrapData property on panel - Githubissues

adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms

Apache License 2.0

26 stars 58 forks source link

FORMS-16446 Add isWrapData property on panel #1412

Open devgurjar opened 2 months ago

devgurjar commented 2 months ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 2 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 2 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	95	96	96	75

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 1 month ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	93	96	96	75

adobe-bot commented 1 month ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.24%. Comparing base (19da0c7) to head (7180a24). Report is 1 commits behind head on dev.

Files with missing lines	Patch %	Lines
...be/cq/forms/core/components/models/form/Panel.java	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1412 +/- ## ============================================ - Coverage 82.27% 82.24% -0.03% - Complexity 923 924 +1 ============================================ Files 103 103 Lines 2369 2371 +2 Branches 321 321 ============================================ + Hits 1949 1950 +1 - Misses 257 258 +1 Partials 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.