POC: Custom EDS fieldTypes - Githubissues

adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms

Apache License 2.0

26 stars 58 forks source link

POC: Custom EDS fieldTypes #1417

Closed TalmizAhmed closed 1 month ago

TalmizAhmed commented 2 months ago

Description

When not providing a fieldType in crx, the fieldType is inferred from the sling model [0]. This PR allows for the fieldType to be overridden in crx with a custom value, such that it should show up in the JSON.

[0] https://github.com/adobe/aem-core-forms-components/pull/1409

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 2 months ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 2 months ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	95	96	96	75

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 2 months ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.43%. Comparing base (77886e9) to head (6204010).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #1417 +/- ## ============================================ + Coverage 82.40% 82.43% +0.02% - Complexity 919 920 +1 ============================================ Files 103 103 Lines 2358 2362 +4 Branches 317 317 ============================================ + Hits 1943 1947 +4 Misses 255 255 Partials 160 160 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-core-forms-components/pull/1417/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/adobe/aem-core-forms-components/pull/1417/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `82.43% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

TalmizAhmed commented 1 month ago

Closing as spec does not want to allow this.