adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms
Apache License 2.0
26 stars 58 forks source link

Removing type button from cq template #1421

Closed rismehta closed 1 month ago

rismehta commented 1 month ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 1 month ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 1 month ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 94 96 96 75
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.40%. Comparing base (839a062) to head (8660cf4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1421 +/- ## ========================================= Coverage 82.40% 82.40% Complexity 919 919 ========================================= Files 103 103 Lines 2358 2358 Branches 317 317 ========================================= Hits 1943 1943 Misses 255 255 Partials 160 160 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-core-forms-components/pull/1421/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/adobe/aem-core-forms-components/pull/1421/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `82.40% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.