FORMS-16264: Remove same instantiation of datetimepicker calendar element - Githubissues

adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms

Apache License 2.0

26 stars 58 forks source link

FORMS-16264: Remove same instantiation of datetimepicker calendar element #1430

Closed anshikag-adobe closed 1 month ago

anshikag-adobe commented 1 month ago

Description

DateTime Picker Element calendar was closing if more than one instance of the widget is created due to same calendar being instantiated for every individual datetimepicker widget.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 1 month ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 1 month ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	94	96	96	75

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 1 month ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 1 month ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	95	96	96	75

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
focus-order-semantics	minor
label-title-only	serious
landmark-one-main	moderate
region	moderate
target-size	serious

adobe-bot commented 1 month ago

Lighthouse scores (mobile)

	Performance	Accessibility	Best-Practices	SEO
Scores	95	96	96	75

adobe-bot commented 1 month ago

Lighthouse scores (desktop)

	Performance	Accessibility	Best-Practices	SEO
Scores	100	96	96	75

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
target-size	serious

adobe-bot commented 1 month ago

Accessibility Violations Found

Id	Impact
label-title-only	serious
page-has-heading-one	moderate
target-size	serious