adobe / aem-core-forms-components

Standardized components to build forms with AEM Forms
Apache License 2.0
26 stars 58 forks source link

FORMS-15484: fix translataion issue with email autocomplete config options #1435

Closed s1mahanty closed 1 month ago

s1mahanty commented 1 month ago

Description

autocomplete is deprecated by granite

Related Issue: FORMS-15484

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.27%. Comparing base (f90346f) to head (70003d9). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1435 +/- ## ========================================= Coverage 82.27% 82.27% Complexity 923 923 ========================================= Files 103 103 Lines 2369 2369 Branches 321 321 ========================================= Hits 1949 1949 Misses 257 257 Partials 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
page-has-heading-one moderate
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
focus-order-semantics minor
label-title-only serious
landmark-one-main moderate
region moderate
target-size serious
adobe-bot commented 1 month ago

Lighthouse scores (mobile)

Performance Accessibility Best-Practices SEO
Scores 93 96 96 75
adobe-bot commented 1 month ago

Lighthouse scores (desktop)

Performance Accessibility Best-Practices SEO
Scores 100 96 96 75
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
adobe-bot commented 1 month ago

Accessibility Violations Found

Id Impact
label-title-only serious
target-size serious
s1mahanty commented 1 month ago

@rismehta the string were always translating, the granite component used had been long deprecated, and this is changed from autocomplete to select component, so that the selected value is the translated string. I have locally validated the same.

rismehta commented 1 month ago

Merging, since the use-case was manually validated