Master65016 oct - Githubissues

rismehta commented 1 month ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes and the overall coverage did not decrease.
[ ] All unit tests pass on CircleCi.
[ ] I ran all tests locally and they pass.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.11%. Comparing base (d925ab7) to head (1406f10).

Files with missing lines	Patch %	Lines
...ponents/internal/models/v1/form/FileInputImpl.java	63.63%	1 Missing and 3 partials :warning:
...ms/core/components/models/form/FileConstraint.java	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## release/650 #1445 +/- ## ================================================= + Coverage 79.02% 79.11% +0.09% - Complexity 777 798 +21 ================================================= Files 92 92 Lines 1840 1872 +32 Branches 272 276 +4 ================================================= + Hits 1454 1481 +27 - Misses 249 252 +3 - Partials 137 139 +2 ``` | [Flag](https://app.codecov.io/gh/adobe/aem-core-forms-components/pull/1445/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/adobe/aem-core-forms-components/pull/1445/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=adobe#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.