adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
743 stars 750 forks source link

childreneditor clientlib issue on author dispatcher #1001

Closed rajeevyadav2 closed 4 years ago

rajeevyadav2 commented 4 years ago

Bug Report

Current Behavior Currently childreneditor clientlib does not have allowProxy property on it. Because of this, Children Editor does not show up on Core components when accessed through dispatcher URL on author.

Expected behavior/code Chidren Editor should show for Tabs and Accordion on Dispatcher URL it these contain children.

Environment

Possible Solution

All allowProxy=true on childreneditor clientlib so that this clientlib is accessible on dispatcher.

Additional context / Screenshots Add any other context about the problem here. If applicable, add screenshots to help explain.

numirov commented 4 years ago

Hi @rajeevyadav2

If i am not mistaken allowProxy just makes clientlib accessible through etc.clientlibs. So with this property clientlib will be accessible by anonymous users on publish env. But it shouldn't matter on author as you are always logged in there. I reckon it has something to do with dispatcher, it might be blocking some requests.

rajeevyadav2 commented 4 years ago

@numirov : if allowproxy is not available then request will try to load the clientlibs from /apps path. /app path is blocked on dispatcher and therefore it never loads.

rajeevyadav2 commented 4 years ago

As a workaround we need to embed this clientlib which has allowproxy true but ideally it should be available through etc.clientlibs as well.

numirov commented 4 years ago

Hi @rajeevyadav2

Most of the editor clientlibs don't have allowProxy, so I believe you better change your dispatcher config to allow /apps for author only.

jckautzmann commented 4 years ago

Most of the editor clientlibs don't have allowProxy, so I believe you better change your dispatcher config to allow /apps for author only.

That's correct, thx. I'll close this issue for now.