search

adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
743 stars 750 forks source link

[Teaser] RTE description adds blank paragraph tags #1105

Closed juliaetate closed 3 years ago

juliaetate commented 4 years ago

Bug Report

Current Behavior When editing the description text for a teaser component, additional empty paragraph tags are being added to the node. These may be added between paragraphs or at the end. The only way to remove them is in CRX/DE, but editing the text again will add additional paragraph tags. This does not happen when I change the node name for the text or to a new RTE field on the component so I believe it is tied to the JS somehow.

Expected behavior/code RTE should not add empty paragraph tags when other text is added.

Environment

Additional context / Screenshots Teaser Issue

sagarkarani commented 4 years ago

This is a valid issue and it takes toll on google pagespeed.

satishkumarjadhav commented 4 years ago

@vladbailescu Could you please confirm if this bug has been prioritized and working on fix ?

gabrielwalt commented 4 years ago

We'll address this issue in the next Core Component release, which we'll try to release by end of Sept, early Oct.

blair-robertson commented 3 years ago

Hello,

I did some investigation into this and it seems to be caused by the custom Teaser JS - probably for enable/disabling the Description RTE based upon the checkbox “Get Description from linked page”

When I disabled the commenting out teaser.js in /apps/core/wcm/components/teaser/v1/teaser/clientlibs/editor/js.txt then the problem disappears.

HTH

msagolj commented 3 years ago

Hi @blair-robertson, thank you for looking into this. I think this is an issue that is purely RTE related (RTE itself is not part of core comp) and got resolved meanwhile in one of the service packs. I tested it with an older version of core comp (2.13) but with 6.5 SP 7, and i was not able to reproduce the issue neither the way @juliaetate (change the description) or you (enable/disable checkbox) described it.

@blair-robertson what AEM Version / SP did you use for testing ?

blair-robertson commented 3 years ago

Hi @msagolj - we are using AEM 6.4.5 with Core Components 2.8.0

OK, we are starting an AEM6.5 migration, so we will be able to test then.

gabrielwalt commented 3 years ago

Closing this for now - this is an RTE issue that the core components have little influence on, and as this might have been improved in more recent AEM versions.