Closed nishneo closed 3 years ago
@adobe export issue to Jira project SITES as Story
@nishneo There was an issue which got fixed in 2.16.0. (see https://github.com/adobe/aem-core-wcm-components/pull/1524) Can you please provide a content package with your custom embeddable which is not displayed in the dialog? Thanks!
@adobe export issue to Jira project SITES
@adobe export issue to Jira project SITES
:white_check_mark: Jira issue SITES-1253 is successfully created for this GitHub issue.
@bpauli Attaching reference package
@nishneo The attached package contains only the video embeddable. My understanding based on your screenshot is that you have problems with the Form Widget embeddable, right? However there was also one property missing in video embeddable so the design dialog always showed the video tab, regardless which embeddable was enabled by the policy configuration.
For more information please see also https://github.com/adobe/aem-core-wcm-components/tree/master/content/src/content/jcr_root/apps/core/wcm/components/embed/v1/embed#custom-embeddable-fragment (step 4 and 6)
Hi @bpauli The issue is when embed component is extended by creating a new embeddable, it is breaking in design dialog as the new embeddable tab(in this case : video) is not getting show/hide on the selection of 'Video' option from 'Allowed Embeddables' dropdown. Expected behavior/code The expectation was design dialogs should work as it works for Youtube(OOTB) embeddable
Below is the screenshot for your reference. Even if the 'Video' option is not selected, 'Video' tab is showing.
Added the same property as mentioned in the previous comment. But still the behavior is same.
Hi @bpauli,
The issue is now fixed after uploading the latest update on the core components. Thank you!!
Bug Report
Current Behavior Trying to extend the Embed component by adding newly embeddable. When creating new embeddable design dialogs, tabs for new embeddable are not coming up when selecting them in the dropdown
Expected behavior/code The expectation was design dialogs should work as it works for Video embeddable
Environment
Additional context / Screenshots