search

adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
733 stars 741 forks source link

ImageImpl v2 - Make proper use of the Sling Delegation Pattern #180

Closed henrykuijpers closed 6 years ago

henrykuijpers commented 6 years ago

https://github.com/Adobe-Marketing-Cloud/aem-core-wcm-components/blob/e0ad89c967cbfc098624a2d4f54d8494e4916658/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v2/ImageImpl.java

This impl class is extending another impl class, but we can now prevent this with Sling Delegation.

vladbailescu commented 6 years ago

Thanks for the suggestion but this a pattern that is appropriately used when extending the implementation is not possible (ie: from a different bundle). There's no need to do that here.