Incorrect use of wcmmode.edit and wcmmode.preview in HTL files

[gquintillan]

Bug Report

Current Behavior

With Touch UI a change of the layer/​mode does no longer lead to a page reload, except for mode 'disabled', therefore we should only use that mode on server-side (even with negation). Every other mode/​layer needs to be treated on client-side.

This can be tested with the accordion component: https://github.com/adobe/aem-core-wcm-components/blob/1b0503ca5d79d5f30615cad939fd26c0a77f46d6/content/src/content/jcr_root/apps/core/wcm/components/accordion/v1/accordion/accordion.html#L17

Edit mode (OK):

Preview mode (KO):

Expected behavior/code The current wcmmode is taken into account.

Environment

• AEM version: 6.5.10.0
• Core Components version: 2.18.0
• JRE version: Java(TM) SE Runtime Environment 18.9 (build 11.0.8+10-LTS)

Possible Solution Use !wcmmode.disabled instead, although it does not differentiate between wcmmode.edit and wcmmode.preview..

I also saw another solution, using initwcm.js, but I did a quick test and I think we will have the same problem:

• https://wcmaem.blogspot.com/2016/07/how-to-check-touch-ui-mode-in-sightly.html
• https://github.com/Adobe-Marketing-Cloud/aem-sites-example-custom-template-type/blob/aa078cc35de7f9d19895a225eb559f4822227251/src/main/content/jcr_root/apps/my-project/components/page/author.html#L18

[ahmadjubair33]

Hi, @adobe @gquintillan Assign this issue to me I will update the HTML file.Thank you

[ncordeiro]

This issue also occurs with embeddables like youtube etc and any custom embeddable written. Kindly suggest