Is your feature request related to a problem? Please describe.
There exist 3 components using the children-editor clientlibs and PanelContainerImpl implementation: Accordion, Carousel, Tabs.
Further there exists a ContainerServlet which handles the children-editor requests. This Servlet is registered to the specific resource types of the three components.
Creating new Accordions, Carousels and Tabs works fine (by delegation), but we want to use the children-editor clientlibs in other components too. Components which should not inherite from these three.
The registration of the ContainerServlet to the specific resource types doesn't allow that.
Describe the solution you'd like
Add a new Panel Container component. Existing three components can use it as sling:resourceSuperType. The ContainerServlet has only to get registered on the Panel Container resource type.
This will not be a breaking change and it will be possible to remove redundant dialog definitions in the existing components.
Further it will be possible to use the children-editor clientlibs in own components.
Are there alternatives?
An own Panel Container Sling model would be helpful - but looking at the code this crashes with AbstractContainer#getDataLayerShownItems.
Feature Request
Is your feature request related to a problem? Please describe. There exist 3 components using the children-editor clientlibs and
PanelContainerImpl
implementation: Accordion, Carousel, Tabs. Further there exists aContainerServlet
which handles the children-editor requests. This Servlet is registered to the specific resource types of the three components.Creating new Accordions, Carousels and Tabs works fine (by delegation), but we want to use the children-editor clientlibs in other components too. Components which should not inherite from these three.
The registration of the
ContainerServlet
to the specific resource types doesn't allow that.Describe the solution you'd like Add a new Panel Container component. Existing three components can use it as sling:resourceSuperType. The
ContainerServlet
has only to get registered on the Panel Container resource type.This will not be a breaking change and it will be possible to remove redundant dialog definitions in the existing components.
Further it will be possible to use the children-editor clientlibs in own components.
Are there alternatives?
An own Panel Container Sling model would be helpful - but looking at the code this crashes with
AbstractContainer#getDataLayerShownItems
.Documentation N/A
I will add a Pull Request.