Closed indra2gurjar closed 1 year ago
Merging #2524 (ab600c3) into main (ce27843) will increase coverage by
0.03%
. The diff coverage is90.10%
.:exclamation: Current head ab600c3 differs from pull request most recent head 527fa4b. Consider uploading reports for the commit 527fa4b to get more accurate results
@@ Coverage Diff @@
## main #2524 +/- ##
============================================
+ Coverage 87.27% 87.31% +0.03%
- Complexity 2623 2645 +22
============================================
Files 229 232 +3
Lines 6986 7063 +77
Branches 1060 1071 +11
============================================
+ Hits 6097 6167 +70
- Misses 358 359 +1
- Partials 531 537 +6
Impacted Files | Coverage Δ | |
---|---|---|
...s/internal/models/v3/NextGenDMImageURIBuilder.java | 87.93% <87.93%> (ø) |
|
...nts/internal/models/v3/NextGenDMThumbnailImpl.java | 91.30% <91.30%> (ø) |
|
.../core/components/internal/models/v3/ImageImpl.java | 95.09% <100.00%> (+1.57%) |
:arrow_up: |
...omponents/models/nextgendm/NextGenDMThumbnail.java | 100.00% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@LSantha @vladbailescu Gentle reminder !
@LSantha @cbogdan0707 I tried incorporating your review feedback. Could you please review?
@indra2gurjar , nice work. Thank you.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
Adding smartcrop functionility to NextGen dynamic media images. Added a new smartcrop button which will open only when a NGDM image is selected. On clicking the button, a dialog will open with UI for taking user input for smartcrop aspect ratios and image preview showing the smartcrop.
https://github.com/adobe/aem-core-wcm-components/assets/10485532/b810dc9d-f041-4340-8fe5-2b9cde91fa31