adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
747 stars 753 forks source link

[Teaser] Inherit from description of asset checkbox improperly hidden #2529

Open ky940819 opened 1 year ago

ky940819 commented 1 year ago

Bug Report

Current Behavior The checkbox for the alt text ("Inherit from description of asset") is improperly hidden in the teaser dialog. This issue can be reproduced in the example project following these steps:

  1. Add a Teaser component to the page
  2. Drag and drop an image onto the teaser component without opening the edit dialog
  3. Open the edit dialog and switch to the "Asset" tab
  4. Note that the "Inherit from description of asset" checkbox is hidden (when it should not be)
  5. Note that the alt text is blank
  6. Save & close the dialog
  7. Note that the required alt text validation was not performed (allowed to save with empty alt text).
  8. Open the dialog again and switch to the "Asset" tab
  9. Drag an image into the dialog asset drop area (or otherwise pick a new image)
  10. Note that the "Inherit from description of asset" checkbox re-appears.

Expected behavior/code The "Inherit from description of asset" checkbox should always be present if an asset is selected.

Environment

Additional context / Screenshots Upon opening the teaser dialog, the checkbox is hidden here:

image

This code was added in commit 07f72d7

Roman-Skripka commented 1 year ago

+1. We see the same issue with 2.22.12