adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
733 stars 740 forks source link

[Text] Wrapping div cmp-text disappears when using inplace editing #2541

Open royteeuwen opened 1 year ago

royteeuwen commented 1 year ago

Bug Report

Current Behavior The Text v2 component has a wrapping div.cmp-text in the text.html HTL template, when using the inplace editing features, it removes this wrapping div, making all CSS rules not match anymore. The recommended approach by Adobe is styling on the cmp-text CSS class, so we have currently no alternative to style the text component

Expected behavior/code The wrapping div.cmp-text should stay

Environment

royteeuwen commented 1 year ago

Followed up in SITES-14663

nhirrle commented 1 year ago

can be fixed with adding editElementQuery=".cmp-text" in https://github.com/adobe/aem-core-wcm-components/blob/main/content/src/content/jcr_root/apps/core/wcm/components/text/v2/text/_cq_editConfig.xml#L9