adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
733 stars 740 forks source link

SITES-14361 - List component added to template structure shows wrong images #2543

Closed LSantha closed 1 year ago

LSantha commented 1 year ago
Q                       A
Fixed Issues? SITES-14361
Patch: Bug Fix? Yes
Minor: New Feature? No
Major: Breaking Change? No
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes? No
License Apache License, Version 2.0
codecov[bot] commented 1 year ago

Codecov Report

Merging #2543 (5e1677b) into main (dd49da0) will increase coverage by 0.05%. The diff coverage is 88.23%.

:exclamation: Current head 5e1677b differs from pull request most recent head d3bf97f. Consider uploading reports for the commit d3bf97f to get more accurate results

@@             Coverage Diff              @@
##               main    #2543      +/-   ##
============================================
+ Coverage     87.22%   87.27%   +0.05%     
- Complexity     2616     2623       +7     
============================================
  Files           229      229              
  Lines          6974     6986      +12     
  Branches       1055     1060       +5     
============================================
+ Hits           6083     6097      +14     
  Misses          358      358              
+ Partials        533      531       -2     
Impacted Files Coverage Δ
...m/core/components/internal/models/v4/ListImpl.java 84.84% <50.00%> (+0.47%) :arrow_up:
...m/core/components/internal/models/v3/ListImpl.java 92.85% <88.88%> (+9.52%) :arrow_up:
...nts/internal/helper/image/AdaptiveImageHelper.java 90.00% <100.00%> (+0.20%) :arrow_up:
.../core/components/internal/models/v1/ImageImpl.java 89.15% <100.00%> (+0.13%) :arrow_up:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication