adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
733 stars 740 forks source link

SITES-13771 - Content Fragment List component : Property Name is getting displayed to users rather than Field Label #2546

Closed HollywoodTonight closed 1 year ago

HollywoodTonight commented 1 year ago
Q                       A
Fixed Issues? SITES-13771
Patch: Bug Fix? Bug fix
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Tries to get the multi text field from "cfm-element" key rather than from the fieldLabel key and falls back on the default value in case is doesn't find anything.

codecov[bot] commented 1 year ago

Codecov Report

Merging #2546 (1ea6dcd) into main (312e3d6) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 1ea6dcd differs from pull request most recent head 0583083. Consider uploading reports for the commit 0583083 to get more accurate results

@@            Coverage Diff            @@
##               main    #2546   +/-   ##
=========================================
  Coverage     87.22%   87.22%           
- Complexity     2615     2616    +1     
=========================================
  Files           229      229           
  Lines          6972     6974    +2     
  Branches       1054     1055    +1     
=========================================
+ Hits           6081     6083    +2     
  Misses          358      358           
  Partials        533      533           
Impacted Files Coverage Δ
...ontentfragment/ModelElementsDataSourceServlet.java 90.00% <100.00%> (+0.52%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication