search

adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
733 stars 741 forks source link

Embed v1 Clientlibs inside v2 components? #256

Closed brandonmaynard closed 6 years ago

brandonmaynard commented 6 years ago

In List v2, there is no mention of embedding a site clientlib. But in List v1, the documentation mentions embedding core.wcm.components.list.v1. Should v2 also embed this clientlib? If so, I think the documentation needs to be updated.

The same thing in regards to Form Container v2 and Form Container v1.

richardhand commented 6 years ago

@brandonmaynard, in the v2 List component we decided to remove the default CSS provided by its site clientlib as it was too opinionated. That's why you don't see it mentioned in the v2 Readme. Styling for the most part should be defined as required in a site clientlib.

It is the same case for the v2 Form Container.

I hope that helps, if you have need any more info, just let us know.

brandonmaynard commented 6 years ago

Thank you @richardhand, this was very helpful.