adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
730 stars 736 forks source link

Adding fallback for forms component #2568

Closed dmaurya929 closed 9 months ago

dmaurya929 commented 1 year ago
Q                       A
Fixed Issues? FORMS-7969
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0
sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5156fbb) 87.34% compared to head (bd46083) 87.34%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2568 +/- ## ========================================= Coverage 87.34% 87.34% Complexity 2648 2648 ========================================= Files 232 232 Lines 7080 7080 Branches 1073 1073 ========================================= Hits 6184 6184 Misses 359 359 Partials 537 537 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dmaurya929 commented 1 year ago

@vladbailescu please help to review and merge this PR. Adding fallback for select panel title for Forms component.

dmaurya929 commented 11 months ago

@vladbailescu please help to review and merge this PR. Adding fallback for select panel title for Forms component.

gentle reminder cc: @vladbailescu

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

LSantha commented 11 months ago

@dmaurya929 , is there a ticket for this PR anywhere, describing the issue, how to reproduce it etc.?

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication