adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
730 stars 736 forks source link

[SITES-16761] Fixed missing toolbar for image component #2605

Closed myronenko closed 9 months ago

myronenko commented 10 months ago

Jira: https://jira.corp.adobe.com/browse/SITES-16761 Added two null pointer checks since authorNs is usually undefined. Since smartcropaction.js was added with https://github.com/adobe/aem-core-wcm-components/commit/b49e22c80a42b8db9c4804b8fe0b72e684cc48df I assume that the focus was NGDM and that's the case when authorNs should be defined. Hence this is a fix for non-NGDM case.

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 10 months ago

Codecov Report

Merging #2605 (a968eda) into main (6a102d1) will not change coverage. The diff coverage is n/a.

:exclamation: Current head a968eda differs from pull request most recent head 99d5b04. Consider uploading reports for the commit 99d5b04 to get more accurate results

@@            Coverage Diff            @@
##               main    #2605   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     2648     2648           
=========================================
  Files           232      232           
  Lines          7078     7078           
  Branches       1073     1073           
=========================================
  Hits           6182     6182           
  Misses          359      359           
  Partials        537      537           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more