search

adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
726 stars 735 forks source link

In place editing is not present in Image Component v3 anymore. #2617

Closed ofarganc closed 8 months ago

ofarganc commented 8 months ago

Bug Report

Current Behavior In Image Component v3, in place editing is not available anymore, while it is available in Image Component v2 it is. Has this feature been removed on purpose? Is it incompatible with v3?

Expected behavior/code In place editing is available in Image Component v3, allowing to crop an image or turn an image.

Environment

Possible Solution Add the inplace editing section from cq:editConfig from v2 into v3

Additional context / Screenshots Adobe documentation still mentions this feature: https://experienceleague.adobe.com/docs/experience-manager-core-components/using/wcm-components/image.html?lang=en#edit-dialog

ofarganc commented 8 months ago

It seems it was removed in this commit: https://github.com/adobe/aem-core-wcm-components/commit/b5860a280570768383c849c00ef90751074abaa5#diff-1e0b6665f26b587e931b46bc1dc29e61f224be84742c7c6fdce1c625081beae2 but it does not mention why anywhere.

vladbailescu commented 8 months ago

That was intentional as we are trying to move away from in-process image transformations via the AdaptiveImageServlet. Instead, you should leverage the OOTB DAM features.