adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
726 stars 735 forks source link

fix: add missing folder in integration tests #2618

Closed buuhuu closed 8 months ago

buuhuu commented 8 months ago

The integration tests added in #2604 may fail with

Caused by: javax.jcr.nodetype.ConstraintViolationException: No default node type available for /apps/core/config
    at org.apache.jackrabbit.oak.plugins.tree.TreeUtil.addChild(TreeUtil.java:232) [org.apache.jackrabbit.oak-security-spi:1.22.16]
    at org.apache.jackrabbit.oak.jcr.delegate.NodeDelegate.addChild(NodeDelegate.java:690) [org.apache.jackrabbit.oak-jcr:1.22.16]
    at org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:321) [org.apache.jackrabbit.oak-jcr:1.22.16]
    at org.apache.jackrabbit.oak.jcr.session.NodeImpl$5.perform(NodeImpl.java:287) [org.apache.jackrabbit.oak-jcr:1.22.16]
    at org.apache.jackrabbit.oak.jcr.delegate.SessionDelegate.perform(SessionDelegate.java:207) [org.apache.jackrabbit.oak-jcr:1.22.16]
    at org.apache.jackrabbit.oak.jcr.session.ItemImpl.perform(ItemImpl.java:112) [org.apache.jackrabbit.oak-jcr:1.22.16]
    at org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:287) [org.apache.jackrabbit.oak-jcr:1.22.16]
    at org.apache.jackrabbit.oak.jcr.session.NodeImpl.addNode(NodeImpl.java:265) [org.apache.jackrabbit.oak-jcr:1.22.16]
    at org.apache.sling.jcr.resource.internal.helper.jcr.JcrResourceProvider.create(JcrResourceProvider.java:451) [org.apache.sling.jcr.resource:3.0.18]

This PR adds the folder that is being created as sling:Folder.

codecov[bot] commented 8 months ago

Codecov Report

Merging #2618 (a5654a7) into main (0efca91) will not change coverage. The diff coverage is n/a.

:exclamation: Current head a5654a7 differs from pull request most recent head 20188a8. Consider uploading reports for the commit 20188a8 to get more accurate results

@@            Coverage Diff            @@
##               main    #2618   +/-   ##
=========================================
  Coverage     87.34%   87.34%           
  Complexity     2648     2648           
=========================================
  Files           232      232           
  Lines          7080     7080           
  Branches       1073     1073           
=========================================
  Hits           6184     6184           
  Misses          359      359           
  Partials        537      537           

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

sonarcloud[bot] commented 8 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication