search

adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
726 stars 735 forks source link

[DataLayer] Removing ACDL also removes datalayer content #2620

Closed brobatr closed 6 months ago

brobatr commented 8 months ago

Bug Report

Current Behavior If the option to remove the ACDL library is used by setting skipClientlibInclude to true, the functionalily in datalayer.js is also removed. This means that information about the components on a page is no longer pushed to the datalayer.

Expected behavior/code skipClientlibInclude should only remove the ACDL library and not affect the datalayer content.

Environment

Possible Solution Split out the ACDL from the clientlib containing datalayer.js so that only the ACDL is removed when skipClientlibInclude is set to true. datalayer.js should then only be removed if the datalayer is disabled

Additional context / Screenshots

datalayer_bug
brobatr commented 8 months ago

hey @vladbailescu if you agree that this is a bug, I can fix it together with the Google datalayer feature