search

adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
726 stars 735 forks source link

[2620] fix datalayer skipClientlibInclude logic #2622

Closed brobatr closed 8 months ago

brobatr commented 8 months ago
Q                       A
Fixed Issues? Fixes #2620
Patch: Bug Fix?
Minor: New Feature? N
Major: Breaking Change? N
Tests Added + Pass? Yes
Documentation Provided N
Any Dependency Changes? N
License Apache License, Version 2.0

The fix separates the ACDL library from the file datalayer.js and thereby allows the exclusion of the ACDL while retaining the datalayer.js logic (assuming datalayer is enabled).

These were previously handled as a single clientlib, core.wcm.components.commons.datalayer.v1 and this could be removed by setting the property skipClientlibInclude in the DataLayerConfig CAC to true.

With this fix the skipClientlibInclude property now only removes the ACDL, leaving a plain array datalayer with the content provided by datalayer.js.

Please see screenshots in issue #2620 to see the issue

sonarcloud[bot] commented 8 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

brobatr commented 8 months ago

mistake in code - will fix and recreate