adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
724 stars 737 forks source link

SITES-19321: Do not show ghost component when no edit mode #2667

Closed hrayrpapikyan closed 5 months ago

hrayrpapikyan commented 5 months ago
Q                       A
Patch: Bug Fix? Yes https://jira.corp.adobe.com/browse/SITES-19321
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Prevent the "ghost" component to be displayed if not EDIT wcm mode

codecov[bot] commented 5 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0862382) 87.34% compared to head (a98a5dc) 87.32%.

Files Patch % Lines
...internal/models/v1/AbstractPanelContainerImpl.java 33.33% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2667 +/- ## ============================================ - Coverage 87.34% 87.32% -0.03% - Complexity 2653 2654 +1 ============================================ Files 232 232 Lines 7097 7100 +3 Branches 1079 1080 +1 ============================================ + Hits 6199 6200 +1 Misses 357 357 - Partials 541 543 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hrayrpapikyan commented 5 months ago

@hrayrpapikyan, would you add a unit test for this fix?

@LSantha , done. Thanks

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud