adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
737 stars 745 forks source link

SITES-16183 - Testing Release Core Components 2.24.0 #2673

Closed LSantha closed 7 months ago

LSantha commented 7 months ago

The test ContentFragmentIT.testSetSingleElement() failed with the message:

Content Fragment first element title should be correctly displayed ==> expected: but was:

The content fragment element title was not displayed for a single line text element representing a title because isMultiline() was incorrectly returning true for this element. In that case the component renders the element not as an element but as a paragraph which doesn't display the element title.

Q                       A
Fixed Issues? SITES-16183
Patch: Bug Fix? yes
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0
sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 7 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (2041d6b) 87.33% compared to head (f441659) 87.28%.

Files Patch % Lines
...els/v1/contentfragment/DAMContentFragmentImpl.java 20.00% 2 Missing and 2 partials :warning:
...core/components/internal/ContentFragmentUtils.java 85.71% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2673 +/- ## ============================================ - Coverage 87.33% 87.28% -0.05% - Complexity 2659 2661 +2 ============================================ Files 232 232 Lines 7105 7117 +12 Branches 1082 1086 +4 ============================================ + Hits 6205 6212 +7 - Misses 357 359 +2 - Partials 543 546 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.