search

adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
724 stars 737 forks source link

ASSETS-33747 named smartcrop in image core v3 component #2676

Closed mohiaror closed 2 months ago

mohiaror commented 4 months ago

Instead of fastly smartcrops, expect named smartcrops in delivery URLs.

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 85.71429% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 87.15%. Comparing base (8fbb567) to head (1566ce3).

Files Patch % Lines
.../core/components/internal/models/v3/ImageImpl.java 86.48% 2 Missing and 3 partials :warning:
...dels/v3/NextGenDMSrcsetBuilderResponseHandler.java 75.00% 0 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2676 +/- ## ============================================ - Coverage 87.17% 87.15% -0.03% - Complexity 2668 2673 +5 ============================================ Files 233 234 +1 Lines 7128 7161 +33 Branches 1090 1095 +5 ============================================ + Hits 6214 6241 +27 - Misses 363 365 +2 - Partials 551 555 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mohiaror commented 2 months ago

Closing this PR in favor of https://github.com/adobe/aem-core-wcm-components/pull/2698