adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
737 stars 745 forks source link

SITES-19937: remove caching in LanguageNavigationSiteRootSelectionStrategy.java #2678

Closed buuhuu closed 7 months ago

buuhuu commented 7 months ago
Q                       A
Fixed Issues? SITES-19937
Patch: Bug Fix? 👍
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

The weak hash map cache causes a flaky behaviour eventually leading to accessing a repository object which's session has already been closed.

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (58c0496) 87.28% compared to head (257d121) 87.28%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2678 +/- ## ========================================= Coverage 87.28% 87.28% + Complexity 2661 2659 -2 ========================================= Files 232 232 Lines 7117 7110 -7 Branches 1086 1084 -2 ========================================= - Hits 6212 6206 -6 Misses 359 359 + Partials 546 545 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.