adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
724 stars 737 forks source link

[SITES-19919] Fixed List (v4) missing teaser image for page with external redirect #2686

Closed myronenko closed 3 months ago

myronenko commented 4 months ago

Jira: https://jira.corp.adobe.com/browse/SITES-19919 There are 3 distinct cases:

First and third cases were handled correctly But in the second case the page was treated as external (3rd case) leading to the missing teaser image The current fix makes sure that in the 2nd case the page is considered internal just like in the 1st case

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.19%. Comparing base (e333b37) to head (0676ada).

Files Patch % Lines
...m/core/components/internal/models/v4/ListImpl.java 0.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2686 +/- ## ============================================ - Coverage 87.21% 87.19% -0.02% Complexity 2665 2665 ============================================ Files 233 233 Lines 7123 7123 Branches 1085 1085 ============================================ - Hits 6212 6211 -1 Misses 362 362 - Partials 549 550 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud