adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
724 stars 737 forks source link

[ClientLibraries] Add option to inject the onload attribute into the stylesheet link tag #2692

Closed vladbailescu closed 2 months ago

vladbailescu commented 4 months ago
sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.21%. Comparing base (0e127b2) to head (280fdb6). Report is 395 commits behind head on main.

:exclamation: Current head 280fdb6 differs from pull request most recent head 5078cfc. Consider uploading reports for the commit 5078cfc to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2692 +/- ## ============================================ + Coverage 86.60% 87.21% +0.61% - Complexity 2313 2673 +360 ============================================ Files 210 233 +23 Lines 6161 7128 +967 Branches 931 1090 +159 ============================================ + Hits 5336 6217 +881 - Misses 329 361 +32 - Partials 496 550 +54 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Andrei-Cornea commented 3 months ago

Hi @vladbailescu is there any plan to add the attribute type for the js script tag as well ? <script type="module" src="main.js">

Best Andrei

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud