adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
724 stars 737 forks source link

ASSETS-33747 named smartcrop in image core v3 component #2698

Closed mohiaror closed 2 months ago

mohiaror commented 3 months ago

Instead of fastly smartcrops, expect named smartcrops in delivery URLs.

Add editor code to render image through delivery URL and support smartcrop.

Bug fixes.

Review comments. Add a separate test case for smartcrop. Add a failing testcase for auto smartcrop.

Incorporate review feedback.

Add test cases for srcset and responsehandler code.


Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.19%. Comparing base (ec57de2) to head (d0c06f5).

:exclamation: Current head d0c06f5 differs from pull request most recent head bdfed59. Consider uploading reports for the commit bdfed59 to get more accurate results

Files Patch % Lines
.../core/components/internal/models/v3/ImageImpl.java 87.17% 2 Missing and 3 partials :warning:
...dels/v3/NextGenDMSrcsetBuilderResponseHandler.java 75.00% 0 Missing and 2 partials :warning:
...s/internal/servlets/NGDMEnableRenderCondition.java 85.71% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2698 +/- ## ============================================ - Coverage 87.20% 87.19% -0.02% - Complexity 2673 2683 +10 ============================================ Files 233 235 +2 Lines 7114 7170 +56 Branches 1081 1097 +16 ============================================ + Hits 6204 6252 +48 - Misses 361 363 +2 - Partials 549 555 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud