Closed mohiaror closed 2 months ago
Attention: Patch coverage is 86.20690%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 87.19%. Comparing base (
ec57de2
) to head (d0c06f5
).:exclamation: Current head d0c06f5 differs from pull request most recent head bdfed59. Consider uploading reports for the commit bdfed59 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code
Instead of fastly smartcrops, expect named smartcrops in delivery URLs.
Add editor code to render image through delivery URL and support smartcrop.
@trivial fix linting errors.
Show smartcrop renditions group even if DM is disabled but polaris is enabled.
Update code to also show dynamicmedia group when dialog is loaded with remote asset.
Make dependency on clientbuilderfactory optional and check for null. This is to avoid rewriting/fixing all Image test cases.
ASSETS-33747 named smartcrop in image core v3 component powered by fastly
Bug fixes.
Minor bug fixes.
Fix test cases.
@trivial Fix existing test cases.
ASSETS-33747 named smartcrop in image core v3 component
Review comments. Add a separate test case for smartcrop. Add a failing testcase for auto smartcrop.
Incorporate review feedback.
@trivial Hide the smartcrop option if remote asset does not have smartcrops.
ASSETS-33747 named smartcrop in image core v3 component
Add test cases for srcset and responsehandler code.
@trivial Move the code to show smartcrop dropdown only after fetching the metadata.
@trivial Fix eslint error.
Fixes #1, Fixes #2