search

adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
723 stars 737 forks source link

[Carousel] Remove attribut duplication on "previous" button #2705

Closed renow-luxembourg closed 2 months ago

renow-luxembourg commented 3 months ago

Bug Report

Current Behavior : In the carousel component, we can define a label and an aria-label attribute on carousel control buttons. It work well on the "Next" button. On the "Previous" button, we can change only the label, its aria-label attribut isn't customizable. This causes restitution differences for people using assistive tool (like the NVDA screen reader).

Expected behavior/code : Keep the same behavior for both "Next" and "Previous" control button.

Environment :

Possible Solution : Removing the aria-label attribut duplication solve the issue.

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

renow-luxembourg commented 2 months ago

Adobe CLA filled and signed.