adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
723 stars 737 forks source link

[SITES-21038] Core Tabs Component Accessibility Issue - Invalid ARIA attribute value #2713

Closed YahorC closed 3 months ago

YahorC commented 3 months ago

Updating tab panel id value, to have connection with tab item aria-controls value, for passing lighthouse report accessibility successfully

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.16%. Comparing base (9e182f4) to head (892492a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2713 +/- ## ========================================= Coverage 87.16% 87.16% Complexity 2668 2668 ========================================= Files 233 233 Lines 7128 7128 Branches 1090 1090 ========================================= Hits 6213 6213 Misses 363 363 Partials 552 552 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.