adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
723 stars 737 forks source link

[Breadcrumb] Add lang attribute to foreign language breadcrumb links #2725

Closed renow-luxembourg closed 2 months ago

renow-luxembourg commented 2 months ago

Feature Request

Current Behavior : In the breadcrumb, the title of pages written in a foreign language (with a custom language defined in advanced properties) are not well rendered to assistive tool (like the NVDA screen reader)

Expected behavior/code : Each page title in the breadcrumb should be vocalized in its appropriate language.

Environment

Possible Solution : Get the language of each destination page in the properties using

Add a conditional lang attribute on the or element when a custom language is defined in advanced property of the page. An additional test could be added to display this attribute only when the language attribute of the element is different of the language of the page.

Additional context : WCAG 2.1 : 3.1.2 Language of Parts (https://www.w3.org/WAI/WCAG21/Understanding/language-of-parts) WCAG 2.1 : Technique H58 (https://www.w3.org/WAI/WCAG21/Techniques/html/H58) RGAA 4.1.2 / RAWeb 1 : 8.7.1 https://accessibilite.public.lu/fr/raweb1/criteres.html#test-8-7-1 (in french)

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

renow-luxembourg commented 2 months ago

Adobe CLA filled and signed.