adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
723 stars 737 forks source link

SITES-21706 Cleanup fastly smartcrop code from core-components repo #2781

Open mohiaror opened 3 weeks ago

mohiaror commented 3 weeks ago
Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0
sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.17%. Comparing base (6bdf5d0) to head (42f44fb).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2781 +/- ## ============================================ - Coverage 87.17% 87.17% -0.01% + Complexity 2683 2676 -7 ============================================ Files 235 233 -2 Lines 7166 7141 -25 Branches 1094 1092 -2 ============================================ - Hits 6247 6225 -22 + Misses 363 362 -1 + Partials 556 554 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mohiaror commented 3 weeks ago

We recently introduced support for sensei based smartcrop in core components and we no longer support fastly based smartcrop which was introduced last year. This PR intends to cleanup the code for fastly based smartcrop.

@vladbailescu , @LSantha Please note removal of an exported API package in this PR. I am not sure if it is recommended to remove the API or not. Considering that the API package only contained 1 class and that too should ideally not be of any use to customers, I think it is safe to delete it altogether. If you feel and advice otherwise then I can follow the conventional method of deprecating the API and throwing the exception from the implementation.