adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
723 stars 737 forks source link

SITES-22935 NGDM remote image issue #2792

Open mohiaror opened 1 week ago

mohiaror commented 1 week ago

Make changes work for multiple fileupload instances present in a custom multifield component.

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0
mohiaror commented 1 week ago

@YahorC I could not understand the change done in this commit - https://github.com/adobe/aem-core-wcm-components/commit/bfc2bd6ce1d7363158d4bec01eb78f90aa3bc372

I am not sure if that change is related to remoteReference (which are used for polaris' connected assets usecase). I tried to incorporate that fix in my PR. Can you please check if it is Ok?

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.21%. Comparing base (b5e6a56) to head (f97f697).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2792 +/- ## ========================================= Coverage 87.21% 87.21% Complexity 2687 2687 ========================================= Files 235 235 Lines 7170 7170 Branches 1096 1096 ========================================= Hits 6253 6253 Misses 363 363 Partials 554 554 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LSantha commented 1 week ago

@mohiaror , could you please add UI test for this fix?

YahorC commented 1 week ago

@mohiaror Changes that I applied was regarding page properties image section So for Image component everything was working fine, but page properties sharing the same logic, but node structure, to which we are referring while trying to fetch image path are different for page properties Image section and just image component Generally fix is looking fine for me, but could you test please, if it works fine for page properties image tab, to make sure it is working fine https://jira.corp.adobe.com/browse/SITES-21939

sonarcloud[bot] commented 23 hours ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud