Open mohiaror opened 1 week ago
@YahorC I could not understand the change done in this commit - https://github.com/adobe/aem-core-wcm-components/commit/bfc2bd6ce1d7363158d4bec01eb78f90aa3bc372
I am not sure if that change is related to remoteReference (which are used for polaris' connected assets usecase). I tried to incorporate that fix in my PR. Can you please check if it is Ok?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.21%. Comparing base (
b5e6a56
) to head (f97f697
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@mohiaror , could you please add UI test for this fix?
@mohiaror Changes that I applied was regarding page properties image section So for Image component everything was working fine, but page properties sharing the same logic, but node structure, to which we are referring while trying to fetch image path are different for page properties Image section and just image component Generally fix is looking fine for me, but could you test please, if it works fine for page properties image tab, to make sure it is working fine https://jira.corp.adobe.com/browse/SITES-21939
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Make changes work for multiple fileupload instances present in a custom multifield component.
Fixes #1, Fixes #2