search

adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
724 stars 737 forks source link

ASSETS-40081 Smart Crop auto rendition is broken with spaces in image… #2804

Open gubhatia opened 5 days ago

gubhatia commented 5 days ago

… name

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0
codecov[bot] commented 5 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.21%. Comparing base (b5e6a56) to head (515f82a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2804 +/- ## ========================================= Coverage 87.21% 87.21% Complexity 2687 2687 ========================================= Files 235 235 Lines 7170 7170 Branches 1096 1096 ========================================= Hits 6253 6253 Misses 363 363 Partials 554 554 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gubhatia commented 5 days ago

@bpauli Could you please review this change? Similar issue was fixed earlier - https://github.com/adobe/aem-core-wcm-components/issues/2140 and looks like it got broken after - https://github.com/adobe/aem-core-wcm-components/commit/d291222136f74ed6183f70d73d59f4653f6587a3