adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
747 stars 753 forks source link

Inconsistent treatment of full-width component dialogs #2870

Open HitmanInWis opened 2 months ago

HitmanInWis commented 2 months ago

For the most part when you open a Core Component dialog, the fields are constrained to a fixed width, and if you use the widget to expand the dialog to full-width the component configuration fields stay neatly contained in the center within a fixed column.

There are a couple exceptions:

  1. Progress Bar config fields expand to about 3/4 screen width.

This is caused by the Progress Bar dialog using cq-RichText-FixedColumn-column, which is likely a copy/paste from the Text component dialog (the only other dialog that uses this) in order to give room for additional RTE content. Since Progress Bar has no RTE in its dialog, this setting should be removed to bring the dialog in line with other components.

  1. Content Fragment and Content Fragment List fields expand to full screen width.

This is caused by missing column wrappers for the fields within the tabs.

                            <columns
                                jcr:primaryType="nt:unstructured"
                                sling:resourceType="granite/ui/components/coral/foundation/fixedcolumns"
                                margin="{Boolean}true">
                                <items jcr:primaryType="nt:unstructured">

Ideally these items are cleaned up for reasons of:

juw177 commented 1 month ago

Also, what is the point of the full screen function when the fields can't expand? Any pathfield that is more than 4 levels deep is cropped and authors need to click on the field and move the cursor to the end to see which page it is pointing to.

If this is being looked at, please address this too.