Open joerghoh opened 1 month ago
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Attention: Patch coverage is 75.00000%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 87.17%. Comparing base (
d2a7b02
) to head (aace37b
).
Files with missing lines | Patch % | Lines |
---|---|---|
...core/components/internal/link/LinkBuilderImpl.java | 75.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Update the AEM Mocks to the latest version; due to changes in https://wcm.io/testing/aem-mock/changes-report.html#a5.5.4 I had to adjust a few locations which are using the Externalizer.
To reduce the effort, I have decided to adjust
LinkBuilder.buildLink
so it will do aResourceResolver.map()
call to calculate theurl
parameter for the Link. Which is not a problem per see, as it would still meet the constraints of the API. But it's no longer identical to the repository path.(Doing it differently would require a major overhaul of the test suite of the inner working of
LinkBuilderImpl
andLinkImpl
.)