adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
746 stars 753 forks source link

#2872 update AEM mocks #2874

Open joerghoh opened 1 month ago

joerghoh commented 1 month ago
Q                       A
Fixed Issues? Fixes #2872
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Update the AEM Mocks to the latest version; due to changes in https://wcm.io/testing/aem-mock/changes-report.html#a5.5.4 I had to adjust a few locations which are using the Externalizer.

To reduce the effort, I have decided to adjust LinkBuilder.buildLink so it will do a ResourceResolver.map() call to calculate the url parameter for the Link. Which is not a problem per see, as it would still meet the constraints of the API. But it's no longer identical to the repository path.

(Doing it differently would require a major overhaul of the test suite of the inner working of LinkBuilderImpl and LinkImpl.)

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.17%. Comparing base (d2a7b02) to head (aace37b).

Files with missing lines Patch % Lines
...core/components/internal/link/LinkBuilderImpl.java 75.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2874 +/- ## ============================================ + Coverage 87.15% 87.17% +0.01% - Complexity 2692 2694 +2 ============================================ Files 235 235 Lines 7188 7191 +3 Branches 1100 1101 +1 ============================================ + Hits 6265 6269 +4 Misses 365 365 + Partials 558 557 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.