Fixed Flaky Test using JSONAssert

Q	A
Fixed Issues?
Patch: Bug Fix?	Yes
Minor: New Feature?	No
Major: Breaking Change?	No
Tests Added + Pass?	N/A
Documentation Provided	Yes (code comments and or markdown)
Any Dependency Changes?	Yes (added jsonassert)
License	Apache License, Version 2.0

Description

Fixed flaky test: com.adobe.cq.wcm.core.components.internal.models.v2.PageImplTest#testPage
The flakiness was due to the nondeterministic order of key-value pairs of the JSONObject returned by expectedReader.read() and outputReader.read(), thereby causing JUnit's assertEquals() method to potentially fail in the testJSONExport() method https://github.com/adobe/aem-core-wcm-components/blob/5f29cc86b17b6db36cc617805295eb951b6504a1/bundles/core/src/test/java/com/adobe/cq/wcm/core/components/internal/models/v2/PageImplTest.java#L137 https://github.com/adobe/aem-core-wcm-components/blob/5f29cc86b17b6db36cc617805295eb951b6504a1/bundles/core/src/test/java/com/adobe/cq/wcm/core/components/Utils.java#L79
This proposed method changes JUnit's assertEquals() to the NON_EXTENSIBLE comparison mode in JSONAssert.assertEquals() that matches all key-value pairs without the strict ordering constraint

How was this tested?

Version of aem-core-wcm-components SHA: 5f29cc

JVM Version

openjdk 11.0.24 2024-07-16
OpenJDK Runtime Environment (build 11.0.24+8-post-Ubuntu-1ubuntu322.04)
OpenJDK 64-Bit Server VM (build 11.0.24+8-post-Ubuntu-1ubuntu322.04, mixed mode, sharing)

The way to reproduce the flaky test failure

Clone the repo:

https://github.com/adobe/aem-core-wcm-components
cd aem-core-wcm-components

Run with NonDex tool

mvn install -pl core -am -DskipTests
mvn -pl bundles/core edu.illinois:nondex-maven-plugin:2.1.7:nondex -Dtest=com.adobe.cq.wcm.core.components.internal.models.v2.PageImplTest#testPage

Test failure screenshot:

adobe / aem-core-wcm-components

Fixed Flaky Test using JSONAssert #2880

Description

How was this tested?

Quality Gate passed