search

adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
744 stars 750 forks source link

[Form Container] Add ability to configure the method from the dialog #448

Closed richardhand closed 5 years ago

richardhand commented 5 years ago

There is currently no possibility to configure the method in the Form Container component. While this is configurable via the component ./method property, it isn't available from the dialog.

PR: https://github.com/adobe/aem-core-wcm-components/pull/447

gabrielwalt commented 5 years ago

Hi @brandonmaynard, why can you not handle data to be submitted via POST? What are your use-cases and/or requirements? Please be as detailed as possible. Is it really the author's decision to choose the method, or would it even be better in your case if only GET would be allowed for a given template or site?

Generally, the best practice is to submit data via POST, and there are likely several WCM form features that only work with POST. Therefore, allowing this method can cause issues for those using it. Also, for most page authors, the distinction between POST and GET is too complex, so it's probably a choice that we don't want to show by default.

Given these considerations, if we really want to add GET support, I'd make it an option for the Design dialog that is disabled by default: a template author then should first enable the GET method in the policy (=Design dialog), before a page author then has the option to choose it in the Edit dialog. But how that exactly has to work would be defined by your use-cases and requirements.

brandonmaynard commented 5 years ago

@gabrielwalt, I am going to close the PR. I agree with you, an author shouldn't be making this decision.