adobe / aem-core-wcm-components

Standardized components to build websites with AEM.
https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html
Apache License 2.0
743 stars 750 forks source link

[Search] Steals tab focus when in AEM Edit mode #957

Closed CezCz closed 3 years ago

CezCz commented 4 years ago

809 Bug Report

Reproduction steps:

Current Behavior After tabbing(focusing) to the search control, we cannot tab out of it.

Expected behavior/code After subsequent tabs we would like to tab to next focusable elements.

Environment

Possible Solution https://github.com/adobe/aem-core-wcm-components/blob/master/content/src/content/jcr_root/apps/core/wcm/components/search/v1/search/clientlibs/site/js/search.js#L264

value of this._elements.results.style.display is "" in edit mode.

This causes:

https://github.com/adobe/aem-core-wcm-components/blob/master/content/src/content/jcr_root/apps/core/wcm/components/search/v1/search/clientlibs/site/js/search.js#L210

To pass, and trigger preventDefault.

Additional context / Screenshots Add any other context about the problem here. If applicable, add screenshots to help explain.

vladbailescu commented 3 years ago

Fixed by #1487