adobe / aem-core-wcm-components

Standardized components to build websites with AEM.

https://docs.adobe.com/content/help/en/experience-manager-core-components/using/introduction.html

Apache License 2.0

740 stars 747 forks source link

[Carousel] Add touch event support #965

Open frappierer opened 4 years ago

frappierer commented 4 years ago

Support for touch events and sliding animation

The carousel component uses display: block and display: none to show and hide the appropriate content.

Problems with this approach

Impossible to have a sliding animation
Touch or drag events, dont trigger slide changes
The need to use third party libraries and rebuild the component from scratch to fill the needs of nearly all our customers
With third party libraries, where slides are stored next to each other, the touch-ui breaks (it is x-offset scrollable).

Suggestion

remove display: block and display: none , and place slides next to each other
register touch events
leave touch-ui non scrollable).

msagolj commented 4 years ago

@frappierer thank you, this is valuable input. Yes the current V1 of the carousel has some limitations in this regard. Your changes would most probably require a new version of the carousel.

Judging by your description you already did some work in that direction. Maybe you can provide a PR as a starting point for the next version ?

frappierer commented 4 years ago

@msagolj we could show you what we did. But we used https://flickity.metafizzy.co/license.html. If Adobe would go that way you/adobe need to acquire the Flickity Commercial Organization License for 320 Dollar. Still interested?

msagolj commented 4 years ago

@frappierer I was more thinking in the line of changes required that makes core components carousel more generic, so its easier to extend. But flickity can be used as an example to see what needs to be done.

AEMBodi commented 2 years ago

Any updates on this one?

jimivine commented 1 year ago

Is there an ETA on when the new version of the Carousel component will be released?

fahol-coop commented 9 months ago

Still no news about that? I think it's a very important feature.

anban02 commented 3 weeks ago

It's been 4 years an we live in a world where mobile devices make up the majority of the users. I think we really need this feature to be able to compete. Can someone please put a priority on this task?