added unit tests and style for card component - Githubissues

adobe / aem-guides-wknd

Tutorial Code companion for Getting Started Developing with AEM Sites WKND Tutorial

https://experienceleague.adobe.com/docs/experience-manager-learn/getting-started-wknd-tutorial-develop/overview.html

MIT License

287 stars 565 forks source link

added unit tests and style for card component #278

Closed sachintec21 closed 2 years ago

sachintec21 commented 3 years ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

davidjgonzalez commented 3 years ago

Hi @sachintec21 ! Nice code!!!

Can you provide a little background on your contribution? Do you see it filling a gap? Or did you accidentally PR this while going through the tutorial?

Thanks! and again - nice code, nice tests!