search

adobe / aem-guides-wknd

Tutorial Code companion for Getting Started Developing with AEM Sites WKND Tutorial
https://experienceleague.adobe.com/docs/experience-manager-learn/getting-started-wknd-tutorial-develop/overview.html
MIT License
286 stars 550 forks source link

Eliminate jQuery dependency #291

Open gknobloch opened 2 years ago

gknobloch commented 2 years ago

Expected Behaviour

No need for jQuery dependency

Actual Behaviour

https://github.com/adobe/aem-guides-wknd/search?q=jquery

Reproduce Scenario (including but not limited to)

N/A

Steps to Reproduce

N/A

Platform and Version

N/A

Sample Code that illustrates the problem

See Github search

Logs taken while reproducing problem

N/A

godanny86 commented 2 years ago

@gknobloch I can take a stab at this. IIRC it was primarily being used for the mobile nav. I still think its nice to show an example of a 3rd party library so may choose to implement with: https://slideout.js.org/. Unless you have any ideas / recommendations...

keepthebyte commented 2 years ago

The main goal is to remove Javascript library dependencies to improve LCP (Largest Contentful Paint) on mobile devices

Tylopilus commented 1 year ago

Is this still needed as clientlibs now load async? It still would be nice to ditch jQuery. As this a simple toggle I would not encourage to use any library but implement this with simple js.