update frontend module with latest dependencies - Githubissues

adobe / aem-guides-wknd

Tutorial Code companion for Getting Started Developing with AEM Sites WKND Tutorial

https://experienceleague.adobe.com/docs/experience-manager-learn/getting-started-wknd-tutorial-develop/overview.html

MIT License

285 stars 548 forks source link

update frontend module with latest dependencies #321

Closed godanny86 closed 2 years ago

godanny86 commented 2 years ago

Description

Updates the ui.frontend module to be aligned with the AEM Project Archetype.

Notably:

Upgrades to webpack 5
Upgrades node to v12.22.7
Upgrades npm to 6.14.0
Uses ESLint for javascript linting

Related Issue

Fix for issue #320

Motivation and Context

Old dependencies can have security vulnerabilities.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

godanny86 commented 2 years ago

@vladbailescu @gabrielwalt if you could take a pass through. Webpack changes are largely to keep in sync with the archetype. Other change is to include the generated grid.css in the ui.frontend module. The main motivation to include the grid is that then ui.frontend code can be used as is for the QSC template in Reference Demos). This deviates a little from the archetype but I think thats the direction we are headed in...