adobe / aem-guides-wknd

Tutorial Code companion for Getting Started Developing with AEM Sites WKND Tutorial
https://experienceleague.adobe.com/docs/experience-manager-learn/getting-started-wknd-tutorial-develop/overview.html
MIT License
286 stars 563 forks source link

SITES-5185 - Ensure all GraphQL Queries to publisher are using Persistent Queries and not POST requests #341

Closed sandru85 closed 2 years ago

sandru85 commented 2 years ago

Description

Disable POST requests for Graphql persisted queries

Related Issue

Motivation and Context

Immutable files should not be different between SDK and archetype.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

godanny86 commented 2 years ago

@sandru85 you will need to regenerate the MD hash for the immutable file in the pom.xml

krystiannowak commented 2 years ago

Thx @godanny86 for a reminder - exactly @sandru85 sth similar as in https://github.com/adobe/aem-guides-wknd/commit/fc34b70622cf047ab5a2fb3c5d27fc4bbf42b22b - you can take archetype after changes in https://github.com/adobe/aem-project-archetype/pull/922 and generate dispatcher's pom.xml and sync hashes from there

sandru85 commented 2 years ago

@krystiannowak @godanny86 I also updated the hash and the file as in https://github.com/adobe/aem-project-archetype/pull/922

godanny86 commented 2 years ago

thanks @sandru85 give me some time to merge this. Several of our tutorials use standard POST requests for GraphQL queries.

sandru85 commented 2 years ago

@godanny86 you can check my comment here https://git.corp.adobe.com/Granite/dispatcher-k8s-base/pull/152#issuecomment-4099643 if you would need to enable the queries on prod

sandru85 commented 2 years ago

@godanny86 any updates on the validation of this? we would have to get ready and introduce it in the archetyp

godanny86 commented 2 years ago

Thanks @sandru85 looks good, i went ahead and merged.