Fix for parallel process not working on windows.

ghost commented 2 years ago

Parallel using ampersand is not supported on windows. npm-run-all enables windows to run watch properly.

Description

Parallel processing using ampersands is not supported on Windows platform. Therefore npm run watch fails to run properly on windows.

Related Issue

Motivation and Context

Following the WKND tutorial and running across this problem has hindered mine and my colleagues progress. We came up with this solution.

How Has This Been Tested?

We tested it on Windows and Linux and it seems to perform as expected.

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[X] I have signed the Adobe Open Source CLA.
[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[X] All new and existing tests passed.

ghost commented 2 years ago

I've signed Adobe open source CLA now.

godanny86 commented 2 years ago

@prupra we tend to keep this project in sync with the AEM Project Archetype. Would you mind performing a PR into that project as well? https://github.com/adobe/aem-project-archetype/blob/develop/src/main/archetype/ui.frontend.general/package.json#L17

ghost commented 2 years ago

@prupra we tend to keep this project in sync with the AEM Project Archetype. Would you mind performing a PR into that project as well? https://github.com/adobe/aem-project-archetype/blob/develop/src/main/archetype/ui.frontend.general/package.json#L17

Sorry for the delay, I will implement this in archetype now.

SachinMali commented 1 year ago

@prupra The 'npm-run-all' needs the associated module, the PR on Archetype Project needs an update. Can you please review it.

Here is the PR, https://github.com/adobe/aem-project-archetype/pull/1017

adobe / aem-guides-wknd